#5126 - Unread notification bugs
-
By PDStig
- Added
- 7 views
| Identifier | #5126 |
|---|---|
| Issue type | Minor issue (breaks specific functionality) |
| Title | Unread notification bugs |
| Status | Completed |
| Handling member | Chris Graham |
| Addon | General / Uncategorised |
| Description | The following issues were found with notifications:
* Viewing (marking read) a single notification does not update / clear the cache of the notifications popup (when you click the bell, the notification still says not read even though it's marked read in digestives_tin... and the bell still has the same number for unread notifications) * While "mark all read" will update the popup and unread notifications counter, there is still a red 0 for unread notifications until next page load; this should probably be removed instead. * When receiving a new notification from the poller, a red 0 appears instead of correctly identifying the number of unread notifications. |
| Steps to reproduce | |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments
delete_cache_entry('_get_notifications', null, $member_id);
$member_id is the from member. We need the to member. Which is not necessarily the same as get_member() (as an admin could be viewing anyone's notification).
2) core_notifications.js has this code
$dom.html(spot, $dom.html(display[0]));
$dom.html(button.firstElementChild, $dom.html(unread[0]));
Which is horrible and needs re-factoring. Pretty sure it's the cause.