#5108 - JavaScript: Triggering submit on forms seems to do nothing

By PDStig
Added 1st Dec 2022, 11:34 AM
3 views

Identifier	#5108
Issue type	Minor issue (breaks specific functionality)
Title	JavaScript: Triggering submit on forms seems to do nothing
Status	Completed
Handling member	Chris Graham
Addon	General / Uncategorised
Description	Running $dom.trigger(form, 'submit') seems to do nothing. This affects the following: * Actions dropdown in admin_shopping Orders screen * Topic/poll actions dropdown (topic) * Marked posts dropdown (topic) It is possible this might also explain, or is even caused by, the fact other forms require clicking the submit button twice before the form submit actually happens: * Giving points "Go" button * Quizzes submission button
Steps to reproduce
Funded?	No

The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated

Comments

By Guest posted 2nd Dec 2022, 8:50 PM

It seems inconsistent whether this does a form submit, which was at the heart of why I had to do such a big reworking of the forms system - as I couldn't rely on it doing submission, or NOT doing submission. For some combination of inconsistency across browsers and change/disagreement of whether this represents some kind of security risk (opaque artificial submission of forms rather than using a direct documented mechanism).
Maybe we will just have to no longer have this, and rely on form.submit();