#4858 - Resource FS error upon changing title of initial Wiki+ page

By Adam Edington
Added 25th Jun 2022, 11:44 PM
4 views

Identifier	#4858
Issue type	Minor issue (breaks specific functionality)
Title	Resource FS error upon changing title of initial Wiki+ page
Status	Completed
Handling member	Chris Graham
Version	10.0.42
Addon	core
Description	PHP WARNING [2] Trying to access array offset on value of type null in sources\resource_fs.php on line 206 (version: 10.0.42, PHP version: 8.0.20
Steps to reproduce
Funded?	No
Commits	Fixed MANTIS-4858 (Code is not defensive about disabled content hooks) (b5368f40) · Commits · Composr ecosystem / Composr · GitLab

The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated

Comments

By Guest posted 27th Jun 2022, 5:38 PM

Automated response: Code is not defensive about disabled content hooks

If a content hook has been modified to be disabled, or somehow is naturally disabled yet other code is using it when it should not be, Composr should be a lot more fault tolerant.

I'm not going to post a hotfix as I changed so many files here.

(I could not reproduce the original bug report without editing the wiki_page content hook's code manually. But I think this fix would solve the issue.)