#4751 - Chunked transfers that have no HTTP payload will stall

By Chris Graham
Added 30th Dec 2021, 4:06 PM
6 views

Identifier	#4751
Issue type	Major issue (breaks an entire feature)
Title	Chunked transfers that have no HTTP payload will stall
Status	Completed
Handling member	Chris Graham
Version	10.0.39
Addon	core
Description	If an HTTP connection results in a chunked transfer, but that chunked transfer is immediately terminated with no data, the downloader will get stuck in an infinite loop (eventually causing a PHP timeout). This patch treats all the edge cases for chunked downloading MUCH more carefully, and comments the code better.
Steps to reproduce
Funded?	No

The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated

Comments

By Guest posted 30th Dec 2021, 4:06 PM

A hotfix (a TAR of files to upload) has been uploaded to this issue. These files are made to the latest intra-version state (i.e. may roll in earlier fixes too if made to the same files) - so only upload files newer than what you have already. If there are files in a hot-fix that you don't have then they probably relate to addons that you don't have installed and should be skipped. Always take backups of files you are replacing or keep a copy of the manual installer for your version, and only apply fixes you need. These hotfixes are not necessarily reliable or well supported. Not sure how to extract TAR files to your Windows computer? Try 7-zip (http://www.7-zip.org/).

By Guest posted 30th Dec 2021, 4:07 PM

Fixed in https://gitlab.com/composr-foundation/composr/commit/f2abc5750

This specifically was caught because a spammer posted a load of Google links, and Google was rate-limiting us doing link checking. It's not common to be rate limited with an empty HTTP body but chunked encoding turned on, but if it happened it was very nasty.