#40 - Topic pinning per-day instead of absolute cost

By Chris Graham
Added 6th Apr 2010, 6:06 AM
8 views

Identifier	#40
Issue type	Feature request or suggestion
Title	Topic pinning per-day instead of absolute cost
Status	Completed
Tags	Risk: Changes core website behaviour (custom)
Handling member	Chris Graham
Addon	ecommerce
Description	Change the topic pinning point-store item to be a per-day cost (like flagrant text is), rather than a one-off cost. A CRON hook will need writing to make this work.
Steps to reproduce
Funded?	No

The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated

Comments

By Guest posted 4th Oct 2013, 7:10 AM

This is now deployed for you :).

I added the max days config option as requested.

You'll probably want to tune the per-day cost down, as it will currently be set at the old flat point rate.

By Guest posted 4th Oct 2013, 10:02 AM

Many thanks for that Chris.
I changed the default to 7 days and kept the same cost.
I then as me went to buy a pinning and it reported that it was going to cost 180 and that I would only have 2 points left - I have many more points than that. It that a display or calcula
tion error ?

I only have my phone at the moment, so I thought that I would switch to a different user, I can enter another username at the bottom of the page but hitting return does nothing - I wonder it it is a iOS 7 and new safari issue. I went to try Chrome but that is not compatible with the Facebook login !!!

Cheers
Ade

By Guest posted 5th Oct 2013, 7:44 AM

Hi Chris,

I am getting a user reporting a bail out - can you take a look please.

http://vwgolfmk1.org.uk/forum/index.php?page=topicview&id=chat%2Fgeneral-chat_3%2Fpinning-topics-for#post_1348556

Cheers
Ade

By Guest posted 5th Oct 2013, 8:44 PM

Regarding that error, I think he put in a post ID instead of a topic ID.

I have not read your earlier post fully yet, but you mentioned a "default". There isn't a default days, there's a maximum days - as requested. Perhaps something is mislabelled, I will check.

By Guest posted 6th Oct 2013, 6:02 AM

Ok, but should it really bail out ?

I have changed the text string to better reflect what is on offer - so that is fine now.

I have raised a separate defect for the iOS 7 one.

Cheers
Ade

By Guest posted 6th Oct 2013, 7:52 AM

"Ok, but should it really bail out ?"

No, I agree. That was just a very quick reply at 2am after a day of restructuring around 150 code files ;).

By Guest posted 6th Oct 2013, 8:08 AM

It will now give a missing resource error, if it can't find the topic.

Regarding the "default", I can see what you mean now when I look at the code again. The code picks a default which is the minimum between 7 and the "Maximum topic pinning days" option. So for example, if "Maximum topic pinning days" is 20, it would default to 7. If "Maximum topic pinning days" was 5, it would default to 5.
In other words, the default has an internal bias towards 7 (a week), but will lower itself down if "Maximum topic pinning days" is not that high.

Regarding you having many more points, perhaps it is a confusion between the two different ways we have of measuring points. We have a calculation for the most ever earned, which is where rank comes from. We also have a calculation of what is unspent, which is what the point-store would run from.