#3305 - Theme Wizard: Wizard does not properly copy custom GLOBAL_HTML_WRAP to new theme

By PDStig
Added 3rd Jun 2017, 11:32 PM
0 views

Identifier	#3305
Issue type	Minor issue (breaks specific functionality)
Title	Theme Wizard: Wizard does not properly copy custom GLOBAL_HTML_WRAP to new theme
Status	Closed (cannot reproduce)
Handling member	Chris Graham
Addon	core_themeing
Description	If the base theme I'm selecting in the theme wizard contains a custom GLOBAL_HTML_WRAP, this does not get copied over to the new theme like it should; Composr instead copies the original template. I have not tested this bug with any other templates, nor any CSS or JS files.
Steps to reproduce
Funded?	No

The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated

Comments

By Guest posted 4th Jun 2017, 3:30 PM

Looking at the code I don't think any templates are copied. The default theme's GLOBAL_HTML_WRAP would be *inherited*.

This may be a bug still though, given expected behaviour of the wizard.

By Guest posted 4th Jun 2017, 3:38 PM

Never-mind, my initial analysis is wrong. Looking deeper now.

By Guest posted 4th Jun 2017, 3:44 PM

Actually under testing it functioned properly - everything was copied from the source theme, including GLOBAL_HTML_WRAP.tpl.

By Guest posted 5th Jun 2017, 3:19 AM

Probably a code override error on my end. I'll investigate my own installation.

By Guest posted 5th Jun 2017, 6:43 AM

Here's the basic call chain.

sources/themewizard.php:make_theme -> themes3.php:actual_copy_theme -> themes3.php:afm_copy.

i.e. make_theme copies the origin theme, which works by doing a directory scan of the origin theme and copying everything from it.