#328 - Remove default banners

By Chris Graham
Added 2nd Dec 2011, 9:57 AM
5 views

Identifier	#328
Issue type	Feature request or suggestion
Title	Remove default banners
Status	Completed
Tags	Risk: Deprecates functionality (custom)
Handling member	Chris Graham
Addon	banners
Description	Remove the default banners bundled with Composr. The Setup Wizard can remove them, but I don't think they should be there any more.
Steps to reproduce
Funded?	No

The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated

Comments

By Guest, By Guest, posted 6th Dec 2011, 11:09 AM

If my .02 is worth anything, I think the default banners are valuable enough to keep. They (of course) act as place holders and have the formatting/sizing necessary to model future banner additions.
The issue I had was the expiration function did not appear to work. The banners continued display after the expiration date.
If they could be disabled, it would allow for future use without them interfering with their regular display on the page...a check box disabling the banner is an alternative to the expiration date (but is not apparently available).

By Guest posted 8th Dec 2011, 8:14 AM

I've just resolved that issue, although it's a minor bug. If there are no banners on active campaigns, it reverts to showing default banners and didn't check the expiry of those.

By Guest, By Guest, posted 27th Jan 2012, 10:54 AM

I agree with Doc Natural "I think the default banners are valuable enough to keep. They (of course) act as place holders and have the formatting/sizing necessary to model future banner additions."
I find that place holder important during the themeing process as a solid reference point. For me, Chris' repair of the minor bug is sufficient at this point.

By Guest posted 19th Feb 2012, 12:54 PM

Feedback taken on board, just killed the "hosting" banner, but kept the "donate" and "advertise here" banners. "Hosting" was way too niche, especially in the age of Facebook Pages, Google Code, cheap cloud instances, etc etc.