#3055 - Custom banner styling issue tutorial

  • By
  • Added
  • 5 views
Identifier #3055
Issue type Minor issue (breaks specific functionality)
Title Custom banner styling issue tutorial
Status Closed (no changes needed)
Handling member Chris Graham
Addon General / Uncategorised
Description The tutorial on adding custom banners tells users to place the following code:

{$SET,BANNER,{$BANNER}} {$,This is to avoid evaluating the banner parameter twice}
{+START,IF_NON_EMPTY,{$GET,BANNER}}
<div class="global_banner" style="text-align: {!en_right}">{$GET,BANNER}</div>
{+END}

The class, global_banner, contains a CSS parameter (used for the default banner): top: -16px; . This means the custom banner will display 16 pixels higher than the user probably would want. It should probably be mentioned in the tutorial that the style attribute in this div should contain a "top: 0px;" to cancel this out.
Steps to reproduce

Funded? No
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated