#3008 - Giftr: Missing username parameter in $post_url in function action_done()

By PDStig
Added 1st Jan 2017, 2:01 AM
0 views

Identifier	#3008
Issue type	Major issue (breaks an entire feature)
Title	Giftr: Missing username parameter in $post_url in function action_done()
Status	Closed (cannot reproduce)
Handling member	Chris Graham
Addon	General / Uncategorised
Description	Missing username parameter in hooks/modules/pointstore/giftr.php in the action_done() function, $post_url variable. It should include username in the URL build, but it doesn't, resulting in "you did not select a username" errors.
Steps to reproduce
Funded?	No

The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated

Comments

By Guest posted 1st Jan 2017, 9:39 AM

That would be a GET parameter, but the receiving code uses a POST parameter, which is the username input on the form. I just tested and it was okay.

I did see a minor bug. If you put in the wrong username it says you didn't specify a user, while it should say the user does not exist. I've fixed that.

By Guest posted 1st Jan 2017, 11:44 AM

I must have an old version of giftr then because my version takes username as a GET parameter... and I know for sure the username I typed in was correct... and after adding the username parameter in to the build URL function, it worked again.

By Guest posted 1st Jan 2017, 11:46 AM

What exact line are you saying reads it as a GET parameter, requires it as a GET parameter, and triggers a failure?

Because there's a get_param_string call in the same function as the form, but that is just a default for the form field. The function that reads in the form using post_param_string.

By Guest posted 1st Jan 2017, 12:57 PM

$post_url = build_url(array('page' => 'pointstore', 'type' => 'action_done2', 'id' => 'giftr', 'gift' => get_param_string('gift', 0), 'username' => get_param_string('username', '')), '_SEARCH'); line 120 on my end. I added the username part.

I see what you mean by post_param_string. I'm wondering why it wasn't working now.

By Guest posted 2nd Jan 2017, 8:19 PM

Right, that's 124 for me. I suspect somewhere this has diverged.