#2919 - Backups fail on readme.txt
-
By PDStig
- Added
- 6 views
| Identifier | #2919 |
|---|---|
| Issue type | Major issue (breaks an entire feature) |
| Title | Backups fail on readme.txt |
| Status | Completed |
| Handling member | Chris Graham |
| Addon | backup |
| Description | Composr's backup system (once again) fails on readme.txt; tries to archive it twice, resulting in failure. |
| Steps to reproduce | |
| Additional information | Composr 10 RC 20 with task queue enabled |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments
[02-Nov-2016 03:40:07 UTC] PHP Notice: Array to string conversion in sources/failure.php on line 387 @ /var/www/vhosts/lovinity.org/httpdocs/data/cron_bridge.php
[02-Nov-2016 03:40:07 UTC] Composr: PHP NOTICE [8] Array to string conversion in sources/failure.php on line 387 (version: 10 RC20, PHP version: 7.0.12, URL: /var/www/vhosts/lovinity.org/httpdocs/data/cron_bridge.php) @ /var/www/vhosts/lovinity.org/httpdocs/data/cron_bridge.php
I can't track those error messages but it's basically a PHP bug that misdirects errors into the wrong file after script execution ends, with the line numbers of where the stack trace starts rather than where the error starts. It could be anything.
Your action was successful.
[03-Nov-2016 21:05:33 UTC] PHP Fatal error: Uncaught Error: Cannot use object of type Tempcode as array in /var/www/vhosts/lovinity.org/httpdocs/sources/tasks.php:135
Stack trace:
#0 /var/www/vhosts/lovinity.org/httpdocs/sources/hooks/systems/cron/tasks.php(45): execute_task_background(Array)
#1 /var/www/vhosts/lovinity.org/httpdocs/sources/misc_scripts.php(309): Hook_cron_tasks->run()
#2 /var/www/vhosts/lovinity.org/httpdocs/data/cron_bridge.php(53): cron_bridge_script('/var/www/vhosts...')
#3 {main}
thrown in /var/www/vhosts/lovinity.org/httpdocs/sources/tasks.php on line 135
[03-Nov-2016 21:05:33 UTC] PHP Error: Uncaught Error: Cannot use object of type Tempcode as array in sources/tasks.php:135
Stack trace:
#0 sources/hooks/systems/cron/tasks.php(45): execute_task_background(Array)
#1 sources/misc_scripts.php(309): Hook_cron_tasks->run()
#2 data/cron_bridge.php(53): cron_bridge_script('/var/www/vhosts...')
#3 {main}
thrown in sources/tasks.php on line 135 @ /var/www/vhosts/lovinity.org/httpdocs/data/cron_bridge.php
The backup completed though.
Be aware the backup system isn't restoring properly, this was a recent issue - the next RC will correct multiple issues with backups.
BTW I had the same problem as Patrick had but with an additional duplicate file. After renaming the readme.txt file, and rerunning the restore.php. The restore_data file popped up as a duplicate as well.
Please note that earlier I indicated that I think my database is corrupted.
When I went back to my site as admin, I get a series of errors--which I also captured, unless you need that capture I'll refrain from uploading. When I went to my site as guest I have no formatting at all.
At this point in time I think the prudent thing is to start from a clean install--I don't really have all that much to redo. Your suggestions please!
I have not attempted to use an older restore_data.php yet.
https://raw.githubusercontent.com/ocproducts/composr/master/sources/database_action.php
It was an error on sites without content translation enabled, which is the majority of sites, but not the test environment I was using previously.