#2510 - Browser and OS not showing on main site, but showing on MSN

By Adam Edington
Added 26th Apr 2016, 4:32 AM
1 view

Identifier	#2510
Issue type	Trivial issue (does not break functionality)
Title	Browser and OS not showing on main site, but showing on MSN
Status	Closed (no changes needed)
Handling member	Chris Graham
Addon	General / Uncategorised
Description	I noticed this was no longer showing when viewing my own profile (forgot to make a ticket), but seeing it on my MSN profile made me post this. What's the difference between the two? Same files I presume.
Steps to reproduce
Funded?	No

The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated

Comments

By Guest posted 26th Apr 2016, 4:32 AM

By Guest posted 26th Apr 2016, 8:17 PM

Likely one site has stats installed and one does not. This data comes out of the stats table.

By Guest posted 27th Apr 2016, 4:06 PM

Both sites are default installs from Git, I have not turned any addons or settings on or off. The main site didn't show it, the MSN site did.

By Guest posted 27th Apr 2016, 4:19 PM

Ok, but it's a different data table anyway - so there'd be some kind of logical reason rather than a bug, not sure what, but I don't think an investigation is needed.

By Guest posted 28th Apr 2016, 1:31 AM

Not seeing this info on my profile on RC8 either, fresh install. Weird.

By Guest posted 29th Apr 2016, 6:45 AM

Tried reopening this, doesn't seem to work. I do think there is an issue here.

By Guest posted 2nd May 2016, 11:52 PM

This is the code:

if (((has_privilege($member_id_viewing, 'show_user_browsing')) || ($member_id_viewing == $member_id_of)) && (addon_installed('stats'))) {
$last_stats = $GLOBALS['SITE_DB']->query_select('stats', array('browser', 'operating_system'), array('member_id' => $member_id_of), 'ORDER BY date_and_time DESC', 1);
if (array_key_exists(0, $last_stats)) {
$user_agent = $last_stats[0]['browser'];
$operating_system = $last_stats[0]['operating_system'];
}
}

There are various cases here for the data not showing, all legitimate:
- User neither has "show_user_browsing" privilege on the site being viewed from nor is viewing their own profile
- stats addon is not installed on the site being viewed from
- No stats data is available on the site being viewed from for that member
- for example because it's configured to not hold long

I'd need to know that a user was being tried who had visited from both sites, that stats was on both sites, and that that user definitely was privileged on both sites or viewing their own profile on both sites.

By Guest posted 3rd May 2016, 11:38 AM

Just the one site, no MSN this time, and it's the admin account I am not seeing these details on.

By Guest posted 4th May 2016, 9:10 PM

Ok, maybe this is why:

if ((get_option('site_closed') == '1') && (get_option('stats_when_closed') == '1')) {
return;
}

If the site is closed and "Collect stats when closed" is not checked, those details won't be gathered.

By Guest posted 9th May 2016, 1:14 PM

That would explain it. I didn't make the link that stats meant the browser and OS. I assumed that was just hit counting and Alexa ranking, etc. Mystery not so mysterious anymore :)