#2293 - Cleaner implementation of some particular ocProducts non-bundled addons
| Identifier | #2293 |
|---|---|
| Issue type | Feature request or suggestion |
| Title | Cleaner implementation of some particular ocProducts non-bundled addons |
| Status | Closed (rejected) |
| Tags |
Risk: Core rearchitecting (custom) |
| Handling member | Chris Graham |
| Addon | core |
| Description | These addons are installed via dynamic code-rewrites, we should allow them to work via hooks:
comcode_whitelist referrals workflows Also composr_homesite_support_credits should not need to override functions, because point functions should use hooks too. |
| Steps to reproduce | |
| Related to | |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments
Another reason would be if I decide to make and release my karma addon. It'd be much easier to implement into the warnings system via. hooks.
1) comcode_whitelist - in v11 branch I have reimplemented this using hooks
2) referrals - in v10 branch I have done something I've called "psuedo-hooks", which is search and replace still but tied to specific static comment markers in the code
3) workflows - this is awkward as there is a lot of overridden code that is too specific for hooks, and the addon really should be a fully integrated feature. For now I want us to merge some changes into core, and make it so other changes only even run if a value flag is set. The addon documentation can say that it is not being maintained and you need to enable the flag. i.e. we'll leave it to rust and turn it off even for dev installs - until we can get some sponsorship to make it a proper integrated feature.
4) composr_homesite_support_credits - change overrides to hooks
5) support hooks in the warning addon
Workflows and hooks for warnings will be discussed in other issues.