#2037 - Drop 'sunk' topics
-
By Chris Graham
- Added
- 1 view
| Identifier | #2037 |
|---|---|
| Issue type | Feature request or suggestion |
| Title | Drop 'sunk' topics |
| Status | Completed |
| Tags |
Risk: Deprecates functionality (custom) |
| Handling member | Chris Graham |
| Addon | core_cns |
| Description | The feature is cute, but not particularly useful. Remove it. |
| Steps to reproduce | |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments
For this feature, it is problematic, but also basically never used by anyone.
Performance issues:
- Navigating to the end of a forum's pagination is a performance hit on large forums due to how MySQL iterates through indexes. We just actually implemented "keyset pagination" for v10 on large forums which means you actually *can't* pagination to the end unless you keep clicking next many many times.
- This could have been resolved, but the existing implementation was flawed. MySQL can only index either progressively ASC or progressively DESC, and if we are sorted with pinned=1 first and sunk=1 last, it couldn't effectively use an index for that. We'd have had to flip the sunk value to resolve it, which would be messy.
- Topic listing was slowed due to the need for an index to incorporate the sunk flag. An index with more fields is less efficient.
- Additionally, that extra indexing would take extra space.
Apart from performance, I'm trying to remove code that is barely used but complicates things, in order to reduce cognitive overhead, translation overhead, reduce the amount that PHP has to parse, the amount the installer has to install, etc. That's really important as the product grows.
I think you can capture the same use case just by having a 'Locked topics' forum. Make a multi-moderation that closed a topic and moves it into there.