#1977 - Installer critical error bail out after recent git commit relating to caching

Identifier #1977
Issue type Major issue (breaks an entire feature)
Title Installer critical error bail out after recent git commit relating to caching
Status Completed
Handling member Chris Graham
Addon General / Uncategorised
Description The addition of the has_caching_for function in sources/caches.php results in an error when running install.php:

Fatal error: Call to undefined function has_caching_for() in E:\xampp\htdocs\composr\sources\lang.php on line 453
Critical error – bailing out

PHP [1] Call to undefined function has_caching_for()
Stack trace…

File -> E:\xampp\htdocs\composr\sources\minikernel.php
Line -> 392
Function -> critical_error
Args -> a:2:{i:0;s:6:"PASSON";i:1;s:52:"PHP [1] Call to undefined function has_caching_for()";}
File -> E:\xampp\htdocs\composr\sources\minikernel.php
Line -> 200
Function -> die_html_trace
Args -> a:1:{i:0;s:52:"PHP [1] Call to undefined function has_caching_for()";}
File -> E:\xampp\htdocs\composr\sources\minikernel.php
Line -> 314
Function -> fatal_exit
Args -> a:1:{i:0;s:52:"PHP [1] Call to undefined function has_caching_for()";}
File -> E:\xampp\htdocs\composr\sources\minikernel.php
Line -> 264
Function -> composr_error_handler
Args -> a:4:{i:0;i:1;i:1;s:44:"Call to undefined function has_caching_for()";i:2;s:40:"E:\xampp\htdocs\composr\sources\lang.php";i:3;i:454;}
Function -> catch_fatal_errors
Args -> a:0:{}
Steps to reproduce

Additional information I believe this only affects install.php. Reverting sources\lang.php line 453 back to the previous version resulted in the same error popping up in sources\lang_compile.php line 45. Adding require_code statements created additional errors. Adding the has_caching_for function directly into install.php seems to be the solution.
Funded? No
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated