#1744 - Fatal PHP error with quick replies when permission for quick replies is turned off

By PDStig
Added 31st Dec 2014, 11:39 AM
1 view

Identifier	#1744
Issue type	Minor issue (breaks specific functionality)
Title	Fatal PHP error with quick replies when permission for quick replies is turned off
Status	Completed
Handling member	Chris Graham
Addon	cns_forum
Description	PHP NOTICE [8] Undefined index: may_use_quick_reply in sources/cns_topicview.php on line 651 (version: 9.0.16, PHP version: 5.4.35, URL: /pg/polls/view/5) The line reads: if ((array_key_exists('message_comcode',$_postdetails)) && (!is_null($_postdetails['message_comcode'])) && (strlen($_postdetails['message_comcode'])<102410/10kb limit, for reasonable performance*/) && ($topic_info['may_use_quick_reply']) && (!array_key_exists('intended_solely_for',$map))) --- When you visit any form of topic where a quick reply box is to be shown, the site will fatally error if the quick reply permission for that user is not active.
Steps to reproduce	1. Go into the Admin Zone 2. Go into permissions 3. Disable quick reply for certain usergroups 4. The members who fall in usergroups that do not have permission to use quick reply will get a fatal PHP error whenever they go to a location on site where they'd typically be presented with a quick reply box.
Funded?	No
Commits	dd24273

The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".

Rating

Unrated

Comments

By Guest posted 6th Jan 2015, 8:38 AM

Sorry for the bug, hotfix coming...

By Guest posted 6th Jan 2015, 8:39 AM

Automated response: Error if quick reply privilege is not enabled

We fixed a subtle quick reply bug in the latest release, but unfortunately introduced a new one.

If quick reply privilege is not enabled, topic viewing will not work.

A workaround would be to enable quick reply, as it is not a dangerous permission to assign (and is on by default). Otherwise, apply this hot fix.

By Guest posted 10th Jan 2015, 10:55 AM

The github link does not function :(

By Guest posted 11th Jan 2015, 6:19 PM

Read the text properly ;).

By Guest posted 11th Jan 2015, 6:52 PM

I did, but I thought "link will become active once code pushed" meant when the hotfix was made.

By Guest posted 12th Jan 2015, 3:24 PM

We'll amend that text for future hotfixes. It means "push" in the git sense, pushing the code to github. Our hotfix script can't do that, I need to manually type a command every now and then.

The hotfixes are always uploaded immediately to the tracker issue, and that's generally what users should get.

By Guest posted 12th Feb 2015, 2:28 PM

I'm re-opening this issue. Although the hotfix does prevent the error, it also gets rid of the "reply" button and seems to also ignore permissions (Administrators can't use quick reply either). So when the hotfix is in place, no one can post anything.

By Guest posted 12th Feb 2015, 2:49 PM

That's definitely not the case. The change is in a branch of code that only effects quick reply, definitely not the reply button. I suspect there's something else, such as the topic closed, or double post permission not being there and the test user being the last poster.