#1548 - The @username functionality implemented on vwgolfmk1.org.uk has gone email notification crazy
-
By Lhasadreams
- Added
- 1 view
| Identifier | #1548 |
|---|---|
| Issue type | Major issue (breaks an entire feature) |
| Title | The @username functionality implemented on vwgolfmk1.org.uk has gone email notification crazy |
| Status | Completed |
| Handling member | Chris Graham |
| Addon | General / Uncategorised |
| Description | One user (a moderator) is reporting in excess of 280 emails being sent to him for the same notification.
He has turned off the Mentions of Me notification for now. I can see the emails in our carbon copy email box. They all point to the profile of one of our members rubjonny "This e-mail from The Mk1 Golf Owners Club was generated automatically and sent to you due to your notification settings. You should not reply directly. You've been mentioned in chipster2407's topic (Topic (#178761)): http://vwgolfmk1.org.uk/forum/index.php?page=topicview&type=misc&id=untitled_8480." "This e-mail from The Mk1 Golf Owners Club was generated automatically and sent to you due to your notification settings. You should not reply directly. You've been mentioned in chipster2407's topic (Topic (#178790)): View topic: - The Mk1 Golf Owners Club." There are hundreds of them. I have noticed a lot of double posting tonight as well, perhaps sending these emails is slowing things down and people are getting frustrated and resubmitting !! Appreciate if some one can take a look. Cheers Ade |
| Steps to reproduce | |
| Funded? | No |
The system will post a comment when this issue is modified (e.g., status changes). To be notified of this, click "Enable comment notifications".
Comments
The member has turned on private topic notifications and the notification itself (saved in actual content - a private topic) contains a mention. I'm not sure the precise scenario, but essentially it is an infinite loop.
Working on a fix...
Specifically, the bug...
Composr parses all its Comcode for something posted, keeps separate note of mentions found, and says to send out mention notifications for everything picked up. However if a member had the mention notification go to a private topic, that would post and Composr would again send out mention notifications for everything already noted - restarting the same send loop of just one member mention notification but in a deeper level of code recursion. That happened until the maximum recursion depth limit in PHP was hit.